Skip to content

feat(i18n-ko): native surfaces and E2E fixtures - #4515

Draft
scs0209 wants to merge 4 commits into
apache:mainfrom
scs0209:feat/i18n-ko-native-e2e-3980
Draft

feat(i18n-ko): native surfaces and E2E fixtures#4515
scs0209 wants to merge 4 commits into
apache:mainfrom
scs0209:feat/i18n-ko-native-e2e-3980

Conversation

@scs0209

@scs0209 scs0209 commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

Wire ko through core locale resolution, desktop native surfaces, and E2E fixtures. This follows the same pattern as #3853 (zh-TW): Korean copy for startup/quit/boot dialogs, diagnostics, notifications, permission overlay, and related main-process fallbacks; E2E fixture flags accept ko / ko-kr without the toLowerCase regression fixed for Chinese locales in #3853 review.

Renderer UiCatalog types require a ko key once ko is in UI_LOCALES. Catalogs outside the #3977–#3979 renderer slices use English stubs for now; session-collaboration-copy includes a real KO block.

Review note: This branch stacks on feat/zh-tw-locale (#3853). GitHub cannot target AcerYue0:feat/zh-tw-locale as the PR base on apache/maka, so the PR currently targets main and includes #3853 commits in the diff. Do not merge until #3853 lands. To review only the Korean work, use:
AcerYue0:feat/zh-tw-locale...scs0209:feat/i18n-ko-native-e2e-3980

Fixes #3980

Verification

  • npm run build:test — pass
  • node --test packages/core/dist/__tests__/ui-locale.test.js — pass
  • node --test apps/desktop/dist/main/__tests__/e2e-fixture-locale.test.js — pass
  • Playwright E2E (ko-locale.spec.ts) — not run locally (dev server not started)
  • npm run lint / npm run format:check — not run for the full workspace

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Cursor — implementation, translation stubs, tests, and PR text. The update(i18n-ko): session-collaboration… commit includes a Generated-by: Cursor trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/XL Under 2500 readable lines label Sep 1, 2026
@scs0209 scs0209 mentioned this pull request Sep 1, 2026
Open
4 tasks
@scs0209
scs0209 force-pushed the feat/i18n-ko-native-e2e-3980 branch 2 times, most recently from 1e37f24 to 16f0432 Compare September 1, 2026 23:10
@github-actions github-actions Bot added effort/XXL Over 2500 readable lines and removed effort/XL Under 2500 readable lines labels Sep 3, 2026
@testikun testikun mentioned this pull request Sep 4, 2026
Open
5 tasks
@ggbdpq

ggbdpq commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Plan for the P1, folded with the two named downstream gaps so the slice lands as one coherent contract change:

  1. Shared predicate in Core next to MessageContent: meaningful content = non-empty text OR quotes.length > 0 OR attachments.length > 0.
  2. Durable admission: normalizeRootTurnMessageContent switches from the text-length rule to the shared predicate, keeping its own attachment-count, trust, and size checks.
  3. Compaction estimate: estimateRuntimeEventChars counts the structured envelope (quote texts + attachment identity) so a structured-only user event is no longer estimated at zero and dropped by the history-compact gate.
  4. Recap: the recap projection switches to the same visibility/content decision instead of content.text.trim().
  5. Verification: storage-level admission unit tests (quote-only accepted; truly empty still rejected with the same frame error), estimate/recap unit tests, and a composition-level test driving a real SQLite-backed turn.start with a quote-only message through idle and queued paths to a durable Turn. Decoder-only examples are excluded per your note; a full Host-subprocess run remains the acceptance bar for closing desktop: quote-only and attachment-only messages require inline text #4804.

This slice deliberately does not touch the empty-bubble half of #4804 (out of scope as agreed). Will start after the current review round settles so the layers land and get re-reviewed together.

@ggbdpq

ggbdpq commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

The durable-admission half is now pinned by tests, pushed in 54a454d: quote-only and attachment-only root Turn inputs are admitted through normalizeRootTurnAdmissionPayload (the seam your end-to-end reproduction proved was rejecting them), and a truly contentless input still throws the same frame error. On the pre-fix base the quote-only and attachment-only cases fail red, matching your reproduction.

Also pushed in fef4f35 (rebase onto current main): the decoder-side structured-content acceptance, the compatibility epoch renumbered to 126 (correctly above main's 125, resolving the collision you flagged), the compaction estimate counting the structured envelope, and the recap carrier placeholder.

Remaining before merge: the composition-level verification you specified (submit → durable admission → snapshot/replay → model input against a real Host subprocess). The storage seam is now proven by unit test; the Host-subprocess run is the piece I will add next.

@heeoneie heeoneie mentioned this pull request Sep 8, 2026
Open
4 tasks
@scs0209
scs0209 force-pushed the feat/i18n-ko-native-e2e-3980 branch from 16f0432 to eef4c42 Compare September 8, 2026 06:00
@heeoneie
feat(i18n-ko): core — add ko to UiLocale model
7b45e32 
Add `ko` to UI_LOCALES so the closed locale vocabulary carries Korean:
the `isUiLocale`/`isUiLocalePreference` guards accept it, and
`resolveSystemUiLocale` recognizes the `ko` prefix through the existing
case-insensitive, `_`-normalizing path (`ko`, `ko-KR`, `ko_KR`,
`ko_KR.UTF-8`), so an `auto` preference resolves to it without being
persisted.

`uiLocaleToIntlLocale` stops being identity. Every locale so far was
already the tag `Intl` wants; bare `ko` leaves the region open, and the
region is what selects Korean date, number, and plural formatting, so it
is widened to `ko-KR`. The return type becomes the literal union of the
tags actually emitted — `'zh-CN' | 'zh-TW' | 'en' | 'ko-KR'` — rather
than `string`, so the set stays visible in the signature. Every call
site feeds an `Intl` constructor, `toLocaleString`, or `localeCompare`,
all of which take `string`, so narrowing it is safe.

The formatter test can no longer assert identity, so it pins the tag
table instead and checks each tag is canonical, which keeps a locale
added later from reaching `Intl` without a deliberate tag.

Refs apache#3975

Generated-by: Claude Code
@heeoneie heeoneie mentioned this pull request Sep 8, 2026
Draft
6 tasks
scs0209 and others added 3 commits September 8, 2026 17:57
@scs0209 @cursoragent
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
2781f91 
…3980)

- Add ko to UI_LOCALES and resolve ko-KR system locales
- Localize startup/quit/boot, diagnostics, and notification native copy
- Add ko E2E fixture flags and ko-locale spec
- Add ko stubs to UiCatalog entries (renderer English fallback until apache#3977–apache#3979)

Generated-by: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@scs0209 @cursoragent
fix(i18n-ko): add Korean copy for session collaboration
27e7dec 
Replace the ko: EN stub with a dedicated KO translation block.

Generated-by: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@scs0209 @cursoragent
fix(i18n-ko): resolve upstream rebase conflicts for Korean locale
9af408a 
- rebase Korean locale commits onto latest upstream/main
- restore catalogs broken by stub insertion and re-add ko stubs
- keep @maka/ui and @maka/core builds green after conflict cleanup

Co-authored-by: Cursor <cursoragent@cursor.com>
@scs0209
scs0209 force-pushed the feat/i18n-ko-native-e2e-3980 branch from eef4c42 to 9af408a Compare September 8, 2026 08:57
@scs0209 scs0209 mentioned this pull request Sep 8, 2026
Closed
@scs0209

scs0209 commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Rebased this branch onto @heeoneie's feat/i18n-ko-core-ui-locale (#5011) per the delivery decision on #3975.

GitHub base is still main for now because feat/i18n-ko-core-ui-locale is not on apache/maka yet. Once that ref is pushed here (or #5011 lands), I can retarget this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

effort/XXL Over 2500 readable lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(i18n-ko): native surfaces and E2E fixtures

3 participants

@scs0209 @ggbdpq @heeoneie